Add additional postgres and redshift time grains#429
Merged
mistercrunch merged 1 commit intoapache:masterfrom May 3, 2016
Merged
Add additional postgres and redshift time grains#429mistercrunch merged 1 commit intoapache:masterfrom
mistercrunch merged 1 commit intoapache:masterfrom
Conversation
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redshift docs: http://docs.aws.amazon.com/redshift/latest/dg/r_Dateparts_for_datetime_functions.html
postgres docs: http://www.postgresql.org/docs/9.1/static/functions-datetime.html
Not sure if it's sensible to test this.
"I tried it and it works" gave 100% coverage for this :D